Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Clean up unused cmd #211

Merged
merged 5 commits into from
Dec 10, 2024
Merged

chore: Clean up unused cmd #211

merged 5 commits into from
Dec 10, 2024

Conversation

gitferry
Copy link
Member

@gitferry gitferry commented Dec 10, 2024 •
edited
Loading

Closes #163. In particular:

  • removed fpd tx command set but moved NewWithdrawRewardCmd and NewSetWithdrawAddressCmd to the root
  • removed default value of --commission-rate as it is a required flag
  • removed rpc SignMessageFromChainKey and relevant functionalities
  • removed fpd export-finality-provider

@gitferry gitferry marked this pull request as ready for review December 10, 2024 14:14
RafilxTenfen
RafilxTenfen approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@RafilxTenfen RafilxTenfen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@gitferry gitferry merged commit 0c0b494 into main Dec 10, 2024
12 checks passed
@gitferry gitferry deleted the gai/cleanup-cmd branch December 10, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafilxTenfen RafilxTenfen RafilxTenfen approved these changes

@Lazar955 Lazar955 Awaiting requested review from Lazar955

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove all the cmd that will not be used for Phase-2
2 participants
@gitferry @RafilxTenfen